Add entry for breaking change doc for 5.0 #18542
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gewarren
requested changes
May 21, 2020
includes/core-changes/corefx/5.0/createcountersetinstance-throws-invalidoperation.md
Outdated
Show resolved
Hide resolved
includes/core-changes/corefx/5.0/createcountersetinstance-throws-invalidoperation.md
Outdated
Show resolved
Hide resolved
includes/core-changes/corefx/5.0/createcountersetinstance-throws-invalidoperation.md
Outdated
Show resolved
Hide resolved
includes/core-changes/corefx/5.0/createcountersetinstance-throws-invalidoperation.md
Outdated
Show resolved
Hide resolved
includes/core-changes/corefx/5.0/createcountersetinstance-throws-invalidoperation.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Genevieve Warren <[email protected]>
Contributor
Author
gewarren
reviewed
May 21, 2020
Contributor
gewarren
left a comment
gewarren
left a comment
There was a problem hiding this comment.
There were a few build warnings, so a couple more things to fix.
includes/core-changes/corefx/5.0/createcountersetinstance-throws-invalidoperation.md
Outdated
Show resolved
Hide resolved
includes/core-changes/corefx/5.0/createcountersetinstance-throws-invalidoperation.md
Outdated
Show resolved
Hide resolved
includes/core-changes/corefx/5.0/createcountersetinstance-throws-invalidoperation.md
Outdated
Show resolved
Hide resolved
includes/core-changes/corefx/5.0/createcountersetinstance-throws-invalidoperation.md
Outdated
Show resolved
Hide resolved
Co-authored-by: Genevieve Warren <[email protected]>
Contributor
Author
@gewarren done thanks! Seems build passed |
gewarren
approved these changes
May 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
InvalidOperationException instead ArgumentException breaking change update
Starting in .NET Core 5.0,
System.Diagnostics.PerformanceData.CounterSet.CreateCounterSetInstance(string instanceName)throws xref:System.InvalidOperationException instead of xref:System.ArgumentException if user attempt to create already existing instance.Related to dotnet/runtime#35717